Address input bugs #122

jordanjones243 · 2024-12-16T21:45:54Z

Alaska Airlines Pull Request

Before Submitting this pull request:

Link all tickets in this repository related to this PR in the Development section
note: all pull requests require at least one linked ticket
If this PR is Ready For Review, all ticket's linked under Development must have their status changed to Ready For Review as well

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.

Summary by Sourcery

Fix input type inconsistencies by changing 'numeric' to 'number' in both code and documentation, enhancing clarity and compliance with HTML standards.

Bug Fixes:

Correct the input type from 'numeric' to 'number' for attributes 'max' and 'min' in the input component documentation and code.

Enhancements:

Update the input mode from 'numeric' to 'number' in the base input component to align with HTML standards.

Documentation:

Revise documentation to reflect the change from 'numeric' to 'number' for input types, ensuring consistency across examples and descriptions.

sourcery-ai · 2024-12-16T21:46:26Z

Reviewer's Guide by Sourcery

This PR addresses input validation and terminology consistency issues. The main changes include updating the input validation logic to properly handle programmatic resets and replacing deprecated 'numeric' type references with the standard 'number' type. The implementation also includes UI improvements for bordered inputs and label positioning.

Class diagram for BaseInput and AuroFormValidation changes

classDiagram
    class BaseInput {
        - String max
        - String min
        - String inputMode
        + handleInput()
    }
    class AuroFormValidation {
        + validateType(elem)
        + validateAttributes(elem)
        + handleInputReset(elem)
    }
    note for BaseInput "Changed inputMode from 'numeric' to 'number'"
    note for AuroFormValidation "Added logic to reset validity state on programmatic reset"

File-Level Changes

Change	Details	Files
Improved input validation handling for programmatic resets	Added condition to reset validity state when input value is programmatically set to undefined Modified validation checks to be independent rather than chained with else-if statements Removed deprecated 'numeric' type check in validation logic	`packages/form-validation/src/validation.js`
Updated terminology from 'numeric' to 'number' throughout the codebase	Updated attribute documentation to use 'number' instead of 'numeric' Renamed example files from 'maxNumeric' and 'minNumeric' to 'maxNumber' and 'minNumber' Updated inputMode assignments to use 'number' instead of 'numeric'	`components/input/demo/api.md` `components/input/docs/partials/api.md` `components/input/docs/api.md` `components/input/src/base-input.js`
Enhanced input styling and layout	Added specific padding for bordered inputs Updated label positioning with standardized spacing variables Modified active label positioning to use consistent spacing	`components/input/src/styles/input.scss` `components/input/src/styles/label.scss`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time. You can also use
this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sun-mota

also, the disabled state colors are off from https://www.figma.com/design/VpUz89Ov6ImBpY5YvzYbZW/Auro-toolkit?node-id=3264-27509&m=dev (not sure if this is the latest design)

sun-mota · 2024-12-18T17:53:16Z

packages/form-validation/src/validation.js

@@ -144,6 +148,9 @@ export default class AuroFormValidation {
        this.validateType(elem);
        this.validateAttributes(elem);
      }
+    } else if (elem.value === undefined) {


validationShouldRun is false, but why do we touch validity?

maybe validationShouldRun should be fixed?

We are touching validity to reset it. In the case of this fix, users expect that validity state to reset when setting the element to value=undefined. Since validationShouldRun is false, it skips the validation logic and resets the validity state.

should we not reset the validity always at the beginning of the validate function? as elem.value is not only case that we want to reset.

jordanjones243 · 2024-12-18T18:43:36Z

also, the disabled state colors are off from https://www.figma.com/design/VpUz89Ov6ImBpY5YvzYbZW/Auro-toolkit?node-id=3264-27509&m=dev (not sure if this is the latest design)

Per this design spec, the disabled colors are correct:
https://www.figma.com/design/tSkHw1uJfDHy0Ml0aDp7Io/branch/SWOHKZpz2K78PPL43uvp5z/Auro-color-palette-(Variables)?node-id=4224-10615&m=dev

The design spec linked in the previous comment is outdated.

packages/form-validation/src/validation.js

chrisfalaska

🚀

jordanjones243 self-assigned this Dec 16, 2024

jordanjones243 changed the base branch from main to beta December 16, 2024 21:46

jordanjones243 marked this pull request as ready for review December 17, 2024 20:16

jordanjones243 requested a review from a team as a code owner December 17, 2024 20:16

jordanjones243 force-pushed the jjones/fixInputBugs branch from 70bff16 to 0caba7e Compare December 17, 2024 20:16

jordanjones243 force-pushed the jjones/fixInputBugs branch from e96a7eb to 480c4e1 Compare December 17, 2024 21:39

sun-mota requested changes Dec 18, 2024

View reviewed changes

jordanjones243 requested a review from sun-mota December 18, 2024 18:43

chrisfalaska requested changes Dec 18, 2024

View reviewed changes

packages/form-validation/src/validation.js Outdated Show resolved Hide resolved

packages/form-validation/src/validation.js Outdated Show resolved Hide resolved

jordanjones243 force-pushed the jjones/fixInputBugs branch 4 times, most recently from ab0c7a0 to 8845302 Compare December 18, 2024 22:47

chrisfalaska previously approved these changes Dec 18, 2024

View reviewed changes

jordanjones243 dismissed chrisfalaska’s stale review via 2ccdf41 December 19, 2024 20:12

jordanjones243 force-pushed the jjones/fixInputBugs branch from 2ccdf41 to 8845302 Compare December 19, 2024 20:13

jordanjones243 added 5 commits December 19, 2024 15:22

fix: validate each individual attribute #119

168392a

fix: remove any instances of type=numeric #120

88eabdf

fix: update layout to match figma #79

d9fd5a4

perf: remove all references of isValid attribute

f37cc4e

perf: reflect value attribute onto component

4177a17

jordanjones243 force-pushed the jjones/fixInputBugs branch from 85d413a to 4177a17 Compare December 19, 2024 23:23

jordanjones243 added 2 commits December 20, 2024 11:24

feat: add reset function to validation script

c3ca030

feat: add reset functionality to input

7438c2d

jordanjones243 added 3 commits December 20, 2024 11:25

feat: add reset functionality to combobox

1f0d735

feat: add reset functionality to datepicker

dd851a1

feat: add reset functionality to select

9a2ad3f

jordanjones243 force-pushed the jjones/fixInputBugs branch from 54eb955 to 9a2ad3f Compare December 20, 2024 19:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Address input bugs #122

Address input bugs #122

jordanjones243 commented Dec 16, 2024 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Dec 16, 2024 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

sun-mota left a comment

sun-mota Dec 18, 2024

jordanjones243 Dec 18, 2024

sun-mota Dec 18, 2024

jordanjones243 commented Dec 18, 2024 •

edited

Loading

chrisfalaska left a comment

Address input bugs #122

Are you sure you want to change the base?

Address input bugs #122

Conversation

jordanjones243 commented Dec 16, 2024 • edited by sourcery-ai bot Loading

Alaska Airlines Pull Request

Before Submitting this pull request:

Summary by Sourcery

sourcery-ai bot commented Dec 16, 2024 • edited Loading

Reviewer's Guide by Sourcery

Class diagram for BaseInput and AuroFormValidation changes

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

sun-mota left a comment

Choose a reason for hiding this comment

sun-mota Dec 18, 2024

Choose a reason for hiding this comment

jordanjones243 Dec 18, 2024

Choose a reason for hiding this comment

sun-mota Dec 18, 2024

Choose a reason for hiding this comment

jordanjones243 commented Dec 18, 2024 • edited Loading

chrisfalaska left a comment

Choose a reason for hiding this comment

jordanjones243 commented Dec 16, 2024 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Dec 16, 2024 •

edited

Loading

jordanjones243 commented Dec 18, 2024 •

edited

Loading